Forums

Posting in these forums is disabled. These forums will be available for archive purposes. Please join the new forums at the links below:

  • yui-support - replaces the `YUI 3.x` and `YUI 3 Gallery` forums.
    We have created the following discussion categories within this group to aid discoverability for these most-used topics:
    • Charts for YUI Charts support.
    • DataTable for YUI DataTable support.
    • Gallery for YUI Gallery support, including support for published Gallery components as well as the Gallery process in general.
    • Tools for support of YUI’s suite of developer tools such as selleck, shifter, grover, yogi, etc.
    • Everything Else for questions that don’t fit one of the categories above, we’ve got you covered here.
  • yui-deprecated - replaces the `YUI 2.x` forum and the forums of other deprecated products (`YUI Doc`, `Builder`, `YUI PHP Loader`, etc.).
  [ 1 post ]
New Topic | Post Reply | Print view
Previous topic | Next topic

Marco Asbreuk

YUI Contributor

  • Username: itsasbreuk
  • Joined: Mon Nov 16, 2009 5:14 am
  • Posts: 520
  • Location: Netherlands
  • Twitter: itsasbreuk
  • GitHub: ItsAsbreuk
  • Gists: ItsAsbreuk
  • IRC: Marco Asbreuk
  • Offline
  • Profile
Tags:
  • github
  • slideshow

Small error

Post Posted: Mon Feb 28, 2011 1:55 pm
Hi Jeff,

I wanted to make use of your slideshow, but it didn't work when rendering on an empty div.
I think there is a small error in your renderUI function:

Code:
if (title.length > 0) { this._setHeaderContents(title);
if (!Y.Lang.isValue(bodyNode)) {
    bodyNode = this._addTemplate(this.TEMPLATES.body);
    this.set('bodyNode', bodyNode);
}}

should be:
Code:
if (title.length > 0) { this._setHeaderContents(title);}
if (!Y.Lang.isValue(bodyNode)) {
    bodyNode = this._addTemplate(this.TEMPLATES.body);
    this.set('bodyNode', bodyNode);
}

Sorry for not posting it on Github: I have not dived in Github yet...
Another small thing: your codeexample mentioned new Y.Slideshow instead of new Y.SlideShow.
Anyway, the slideshow works great now. Thanks for letting me take use of it.

Kind Regards,
Marco.
  [ 1 post ]
New Topic | Post Reply | Print view
Previous topic | Next topic
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum