Pull Request from rtsai2000
Commit: http://github.com/rtsai/yuicompressor/commit/a04c8d4239b69db2c3e1172f52f006e8c8f2cadf
Files modified:

• ant.properties
• src/com/yahoo/platform/yui/compressor/JavaScriptCompressor.java
• src/com/yahoo/platform/yui/compressor/YUICompressor.java

Ticket moved from: http://yuilibrary.com/projects/yuicompressor/ticket/2528051

Ticket moved from: http://yuilibrary.com/projects/builder/ticket/21

Signed off.

Signed off.

I've already removed the warning, so this patch should not be necessary. From the latest github source:

if (symbol.length() <= 3 && !builtin.contains(symbol)) {
// Here, we found an undeclared and un-namespaced symbol that is
// 3 characters or less in length. Declare it in the global scope.
// We don't need to declare longer symbols since they won't cause
// any conflict with other munged symbols.
globalScope.declareIdentifier(symbol);

// I removed the warning since was only being done when
// for identifiers 3 chars or less, and was just causing
// noise for people who happen to rely on an externally
// declared variable that happen to be that short. We either
// should always warn or never warn -- the fact that we
// declare the short symbols in the global space doesn't
// change anything.
// warn("Found an undeclared symbol: " + symbol, true);
}

Adam: Okay. Shouldn't the appropriate fix be to always warn, regardless of symbol length, unless specified in --globals?

I don't think the globals option is necessary at all (this warning was removed some time ago -- before this patch). I think the warning was a red herring, possibly because at one time the compressor didn't handle the potential collision with short symbols (the compressor generates symbols for obfuscation up to 3 chars in length). It does handle this now, so there isn't really anything to warn about.

My suggestion is to revert the patch; the warning has already been removed.

Adam: Thanks for your explanation. I was testing this change with an older YUI Compressor we're using for our build system which doesn't have your patch.

I'll revert it.

Reverted on yuisource.

Is there another yuicompressor branch somewhere that I should be using? Using http://github.com/yui/yuicompressor , I see the following in my build output:

YuiSharedTargets.minify:
[echo] Running yuicompressor on /Users/rob/work/myphotos/messageread/src/apiclients/build_tmp/pp-ymailclient.js
[java]
[java] [WARNING] Found an undeclared symbol: YUI
[java] ---> YUI <--- .add("pp-ymailclient",function(Y){
[echo] Running yuicompressor on /Users/rob/work/myphotos/messageread/src/apiclients/build_tmp/lang/pp-ymailclient.js

Sorry about that, I hadn't checked in one of the changes that gets rid of that. It is there now.