Ticket #2532764 (closed defect)
Reporter paulallies |
Opened: 09/19/12 Last modified: 12/12/12 Status: closed Type: defect Resolution: fixed |
Owner  Dav Glass |
Target Release: 3.7.2 Priority: P1 (critical) |
|---|---|---|---|
| Summary: | fetchCSS in yui loader not working. | ||
| Description: | when setting the fetchCSS of the YUI loader to "false" the loader still fetches the css of the widget. |
||
| Type: | defect | Observed in Version: | 3.7.0 |
| Component: | Loader | Severity: | S2 (high) |
| Assigned To: | Dav Glass | Target Release: | 3.7.2 |
| Location: | Library Code | Priority: | P1 (critical) |
| Tags: | Relates To: | ||
| Browsers: | N/A | ||
| URL: | |||
| Test Information: | |||
Change History
|
Posted: 09/19/12
|
Jenny Donnelly
|
Posted: 09/19/12
|
|
Posted: 09/19/12
|
|
Posted: 09/20/12
This is a pretty critical bug that affects anybody who doesn't want the YUI injected CSS. If everything was properly wrapped, it would be less of a big deal, but for things like buttons the CSS is applied without any selection, thus creating some pretty crummy UIs. |
|
Posted: 09/20/12
This is too severe of a bug to leave in the backlog. Breaking a core YUI config property without a workaround prevents users from being able to upgrade from 3.6. This is a fix that needs to get into a 3.7.2 patch release ASAP |
|
Posted: 09/20/12
Sorry guys, I didn't put this in the backlog and I've been working on it since I saw it. I didn't see the first comment since the "auto backlog update" spammed me with ~100 emails yesterday. I kind of lost it.. I should have a patch to test within the hour and I'll bring up the 3.7.2 at our staff meeting this afternoon. |
|
Posted: 09/20/12
Damn, that comment was delayed.. I have a working version here: http://jsfiddle.net/davglass/qhQ9U/ I'm currently writing tests to make sure it doesn't happen again, then it will get into the build. |
|
Posted: 09/20/12
Here's the Pull Request with the fix and test: |
|
Posted: 09/20/12
Thanks very much Dav, appreciate it. Can't wait for 3.7.2 :) |
|
Posted: 09/20/12
Thanks a lot Dav! |
|
Posted: 09/20/12
Hi Brett, this bug got swept into the backlog as part of a larger cleanup, but we are addressing ASAP. Sorry for the misunderstanding! |
|
Posted: 09/20/12
Yep, thanks for the quick resolution. Hope to see 3.7.2 soon. |
|
Posted: 09/20/12
Thanks guys. Looking forward to 3.7.2 |
|
Posted: 09/20/12
Just merged this in, once the build completes (and passes) I'll start he deployment. |
|
Posted: 09/20/12
Fixes #2532764 - If fetchCSS is false, kill the css array to be safe |
|
Posted: 09/20/12
Fixes #2532764 - If fetchCSS is false, kill the css array to be safe |
|
Posted: 09/24/12
|
|
Posted: 09/24/12
|
|
Posted: 09/25/12
Fixes #2532764 - If fetchCSS is false, kill the css array to be safe |
|
Posted: 12/12/12
|
Moving from 3.NEXT to BACKLOG.