Ticket #2532747 (closed defect)

Reporter


Ryan Grove
Opened: 09/12/12
Last modified: 12/12/12
Status: closed
Type: defect
Resolution: fixed

Owner


Dav Glass
Target Release: 3.7.0
Priority: P3 (normal)
Summary: The switch to UglifyJS breaks some custom combo handlers and build scripts
Description:

UglifyJS omits semicolons and trailing newlines at the end of a minified file, whereas YUI Compressor didn't omit semicolons, and always left a trailing newline. This causes breakage in custom combo
handlers, concat scripts, and other tools that combine minified YUI modules without inserting a newline after each module.

I recommend that shifter automatically append a newline to every minified file to prevent this breakage.

Type: defect Observed in Version: 3.7.0pr2
Component: YUI Global Object Severity: S3 (normal)
Assigned To: Dav Glass Target Release: 3.7.0
Location: Library Code Priority: P3 (normal)
Tags: Relates To:
Browsers: N/A
URL:
Test Information:

Change History

Ryan Grove

YUI Developer

Posted: 09/12/12

Also, in case it's not obvious, any YUI module that was built with Uglify for 3.7.0pr2 will need to be rebuilt after this is fixed.

Dav Glass

Posted: 09/13/12
  • milestone changed to 3.7.0
  • status changed from new to accepted

On it for the PR today, just fixed issue 15 on shifter to fix this internally.

Dav Glass

Posted: 09/13/12

Full lib built and pushed to our build machine.

Dav Glass

Posted: 09/13/12
  • status changed from accepted to checkedin

Jenny Donnelly

YUI Developer

Posted: 12/12/12
  • resolution changed to fixed

Jenny Donnelly

YUI Developer

Posted: 12/12/12
  • status changed from checkedin to closed