Ticket #2532168 (closed defect)
Reporter Scott Steffens |
Opened: 04/18/12 Last modified: 08/1/12 Status: closed Type: defect Resolution: fixed |
Owner  Dav Glass |
Target Release: 3.6.0 Priority: P3 (normal) |
|---|---|---|---|
| Summary: | YUI config does not properly override skins | ||
| Description: | We have a sample of our CONFIG parameter that we pass in here: We override some skins with an empty array to avoid loading the default skins. Repro: Actual: This results in a large performance degradation; our hack for the meantime is to edit the yui/yui.js file directly. |
||
| Type: | defect | Observed in Version: | 3.5.0 |
| Component: | Loader | Severity: | S3 (normal) |
| Assigned To: | Dav Glass | Target Release: | 3.6.0 |
| Location: | Library Code | Priority: | P3 (normal) |
| Tags: | skins config | Relates To: | |
| Browsers: | N/A | ||
| URL: | http://jsfiddle.net/UYEvU/ | ||
| Test Information: | |||
Change History
|
Posted: 04/18/12
|
|
Posted: 04/18/12
|
|
Posted: 04/18/12
|
|
Posted: 04/18/12
I might be able to provide a "patch" but a gallery module won't help any since it's in Loader and Loader is needed to process the modules. |
|
Posted: 04/18/12
that would be great! currently we're modifying yui.js and changing the skinnable attribute to false for those modules whose css we don't want. |
|
Posted: 04/18/12
Can you use the seed file and config in this Fiddle and give it a test for me? |
|
Posted: 04/18/12
I've tested this and it worked. Can we get both yui.js and yui-min.js? |
|
Posted: 04/18/12
It's built, so you can use any of them -min/-debug or .js.. I'll get this merged into master and pushed to the main repo shortly. |
|
Posted: 04/18/12
Awesome, thank you. |
|
Posted: 04/18/12
Pushed to our build machine, should be on Github in 10-15 minutes or so. |
|
Posted: 04/18/12
Fixes #2532168 - Override skins not being applied |
|
Posted: 04/18/12
Ref #2532168 - Skip the auto skin for internal modules |
|
Posted: 05/30/12
It looks like 'console' also uses 'sam' and might need to be changed like 'test'. |
|
Posted: 05/30/12
@Walter - What do you mean? |
|
Posted: 05/30/12
Actually, seems to be a problem in my environment. I stumbled across this and thought I had worked around it locally, but had problems with console not behaving the way I expected. Patched our local YUI 3.5 and all is good. |
|
Posted: 08/1/12
Shipped in 3.6.0. Marking closed/fixed. |
Jenny Donnelly
any chance we could get a gallery module to fix this sooner than 3.6.0? pretty please? :)