YUI 3

Ticket #2531855 (closed enhancement)

Reporter


John Lindal 		Opened: 03/6/12
Last modified: 04/19/12
Status: closed
Type: enhancement
Resolution: wontfix

Owner


Dav Glass 		Target Release: 3.6.0
Priority: P3 (normal)
Summary: YUI instance's combine:false should override group's combine:true
Description:

First, I configure a group:

window.YUI_config =
{
groups:
{
ygallery:
{
ext: true,
combine: true,
base: 'http://localhost:8666/combo?',
comboBase: 'http://localhost:8666/combo?',
root: '',
patterns:
{
'ygallery-': { },
'lang/ygallery-': { },
'ygallerycss-': { type: 'css' }
}
}
}
}

Then I require them:

YUI({
filter: 'debug', combine: false,
gallery: 'gallery-2012.01.11-21-03'
}).use('ygallery-foo', 'ygallery-blah', function(Y) {...});

When I view the generated source in Firefox, I see this script request:

http://localhost:8666/combo?ygallery-foo/3.5/ygallery-foo-debug.js&ygallery-blah/1.5/ygallery-blah-debug.js

I think the combine:false configuration for the YUI instance should override the group's combine:true configuration.

In addition, I think that Loader should fall back on using comboBase even for single modules, if base isn't defined.
Type: enhancement Observed in Version: 3.5.0pr2
Component: Loader Severity: S4 (low)
Assigned To: Dav Glass Target Release: 3.6.0
Location: Library Code Priority: P3 (normal)
Tags: Relates To:
Browsers: N/A
URL:
Test Information:

Change History

Dav Glass
Posted: 03/6/12
  • location changed to Library Code
  • milestone changed to 3.6.0
  • priority changed to P3 (normal)
  • status changed from new to accepted

I don't see this as a bug, the group always overrides the main config, it's the same thing as you saying this:



YUI_config = {

     combine: false,

     groups: {

          combine: true

     }

}

The group wins, since it's more specific.

Under the hood, we just reassign the config to Loader during a group config.

Now, I can "maybe" see mixing the config instead of clobbering, but that will change the way the logic works and has worked since the beginning and may cause issues with current users.

I'm not sure if this is even the right thing to do, but I will look into it for 3.6.0 and discuss it with the team then.

John Lindal

YUI Contributor
Posted: 03/8/12

I see your point, but from a usability perspective, if I want to turn on debugging, then I want to set filter to "raw" or "debug" and combine=false only on my YUI instance, since I might not have control over the group definitions.

Dav Glass
Posted: 04/19/12
  • resolution changed to wontfix
  • status changed from accepted to closed

This is not a change I feel comfortable making, there are many times I want to combine a group but not combine the main modules. Changing this, changes the entire point of group overrides.

© 2006-2013 Yahoo! Inc. All rights reserved.
All code on this site is licensed under the BSD License unless stated otherwise.
About This Site · Security Contact Info