Ticket #2531557 (accepted enhancement)

Reporter


Patrick Cavit
Opened: 12/7/11
Last modified: 09/19/12
Status: accepted
Type: enhancement

Owner


Allen Rabinovich
Target Release: 3.CURRENT.NEXT
Priority: P3 (normal)
Summary: Y.DataType.Number.parse uses Y.mix weirdly
Description:

Y.DataType.Number.parse uses a combination of Y.mix & Y.namespace to add a single key to the object returned by Y.mix. This seems rather inefficient compared to simply adding a key to the object
Y.namespace returns.

Foxxtrot in IRC posited that it might be so that it wouldn't override any pre-existing key, but it still seems faster to just wrap the assignment in a truthiness check rather than going all the way
through Y.mix.

Type: enhancement Observed in Version: development master
Component: DataType-Number Severity: S3 (normal)
Assigned To: Allen Rabinovich Target Release: 3.CURRENT.NEXT
Location: Priority: P3 (normal)
Tags: Relates To:
Browsers: All
URL: https://github.com/yui/yui3/blob/master/src/datatype/js/datatype-number-parse.js#L11
Test Information:

Change History

Allen Rabinovich

YUI Developer

Posted: 02/1/12
  • milestone changed to 3.6.0
  • priority changed to P3 (normal)
  • status changed from new to accepted

Allen Rabinovich

YUI Developer

Posted: 07/18/12
  • sprint changed to backlog

Allen Rabinovich

YUI Developer

Posted: 07/27/12
  • milestone changed from 3.6.0 to 3.7.0
  • sprint changed from backlog

Jenny Donnelly

YUI Developer

Posted: 08/1/12
  • milestone changed from 3.7.0 to 3.6.x

Moving 3.7.0 bugs to 3.6.x for triage.

Jenny Donnelly

YUI Developer

Posted: 09/19/12
  • milestone changed from 3.6.x to 3.CURRENT.NEXT

Moving from 3.6.x to 3.CURRENT.NEXT