YUI 3

Ticket #2530978 (closed defect)

Reporter


John Iannicello 		Opened: 08/24/11
Last modified: 09/27/11
Status: closed
Type: defect
Resolution: fixed

Owner


Eric Ferraiuolo 		Target Release: 3.4.1
Priority: P3 (normal)
Summary: Panel header text and close image not aligned
Description:

I noticed that the background image for the Panel header was missing in IE 7 and 8. Also, or because of this, the header text was aligned towards the top while the close button is on the bottom and
there is extra height in the header. If you view this example of panel in IE 7 or 8 you'll see what I mean: http://yuilibrary.com/yui/docs/panel/panel-form-example.html

I needed to put this css work around for IE 7 and 8 which is in the enclosed sample.
Type: defect Observed in Version: 3.4.0
Component: Panel Severity: S3 (normal)
Assigned To: Eric Ferraiuolo Target Release: 3.4.1
Location: Library Code Priority: P3 (normal)
Tags: Relates To: #2530952, #2531079
Browsers: IE 7.x,IE 8.x
URL: http://yuilibrary.com/yui/docs/panel/panel-form-example.html
Test Information:

Attachments

Attachment #1: TestPanel.html (download)

Change History

Tilo Mitra

YUI Developer
Posted: 08/24/11

Seems like a CSS fix.

Eric Ferraiuolo

YUI Developer
Posted: 08/24/11
  • location changed to Library Code
  • milestone changed to 3.4.1
  • status changed from assigned to accepted

Eric Ferraiuolo

YUI Developer
Posted: 08/24/11
  • estimated changed from 0 to 0.25
  • remaining changed from 0 to 0.25
  • sprint changed to sprint 1

Eric Ferraiuolo

YUI Developer
Posted: 08/29/11
  • relatesto changed to 2530952

Eric Ferraiuolo

YUI Developer
Posted: 09/9/11
  • relatesto changed from 2530952 to 2530952, 2531079

Eric Ferraiuolo

YUI Developer
Posted: 09/13/11
  • completed changed from 0 to 0.50

Eric Ferraiuolo

YUI Developer
Posted: 09/13/11
  • completed changed from 0.5 to 0.4
  • remaining changed from 0.25 to 0.1

Eric Ferraiuolo

YUI Developer
Posted: 09/13/11
  • completed changed from 0.4 to 0.5
  • remaining changed from 0.1 to 0
  • status changed from accepted to checkedin

Eric Ferraiuolo

YUI Developer
Posted: 09/16/11
  • resolution changed to fixed

Improved Panel's CSS and button layout.

WidgetButtons' `buttons` attribute now support a `classNames` property which
will add CSS classes to the button Node. The default close button uses this to
add `yui3-button-close` CSS class to itself. This change made it much easier to
target the default styling of the close button and the styling that the Panel
skins add. Relates to #2530952

Panel got its CSS reworked a bunch, especially for the CSS responsible for
laying out the Panel's buttons. The `panel-core.css` is now much cleaner and
only has style rules for the things that are layout specific while being skin
agnostic. The styling for Panel's header is now much more flexible, while
maintaining the position of the close button across browsers and various
amounts of content. Fixes #2530978

Panel's Sam Skin CSS got a once over to tidy it up, while Panel's Night Skin
underwent some major updates to make it's style work across more browsers.
View Commit: b6404034932ef0457b7eaffed707df8a48bf1681

Jenny Donnelly

YUI Developer
Posted: 09/27/11
  • status changed from checkedin to closed

© 2006-2013 Yahoo! Inc. All rights reserved.
All code on this site is licensed under the BSD License unless stated otherwise.
About This Site · Security Contact Info