Ticket #2530563 (closed defect)

Reporter


Jenny Donnelly
Opened: 07/23/11
Last modified: 08/18/11
Status: closed
Type: defect
Resolution: fixed

Owner


Dav Glass
Target Release: 3.4.0
Priority: P3 (normal)
Summary: Slider one-off skins not being loaded
Description:

Slider has one-off skins, like sam-dark and capsule that are being built into /build/slider-base/assets/skins/.

The following code does not load these skin files:

YUI({
skin: {
overrides: {
slider: [
'sam', // The default skin
'sam-dark', // Suited for dark backgrounds

'capsule', // You only need to include one skin
'capsule-dark', // in the overrides section unless you
// are using multiple skins on the same page
'round',
'round-dark',

'audio-light',
'audio'
]
}
}
}).use('slider', function ( Y ) {

Test pages:
yui3/src/slider/tests/manual/skins.html
http://stage.yuilibrary.com/yui/docs/slider/slider-skin.html

Type: defect Observed in Version: development master
Component: Loader Severity: S3 (normal)
Assigned To: Dav Glass Target Release: 3.4.0
Location: Library Code Priority: P3 (normal)
Tags: Relates To:
Browsers: N/A
URL:
Test Information:

Change History

Dav Glass

Posted: 07/25/11
  • estimated changed from 0 to 0.10
  • remaining changed from 0 to 0.10
  • sprint changed to sprint 3
  • status changed from new to accepted

Jenny Donnelly

YUI Developer

Posted: 07/25/11

For 3.4.0, we'll copy the skin files to the "slider" build directory. After 3.4.0, we'll resolve how these override skin files get built and loaded: I will open a separate ticket to track that issue.

Jenny Donnelly

YUI Developer

Posted: 07/25/11

Jenny Donnelly

YUI Developer

Posted: 07/25/11

Jenny Donnelly

YUI Developer

Posted: 07/25/11
  • status changed from assigned to accepted

Specifying

YUI({skin: {
overrides: {
"slider-base": ["foo", "bar"]

works as expected. However, keeping "overrides" to "slider" and copying the skin files to a "/build/slider" directory does *not* work. Wondering what else is required to make this work, since the "/build/slider" directory is now a totally one-off special case directory.

Jenny Donnelly

YUI Developer

Posted: 07/25/11

Back to you Dav :-)

Dav Glass

Posted: 07/26/11
  • completed changed from 0 to 0.1
  • remaining changed from 0.1 to 0
  • status changed from assigned to checkedin

Dav Glass

Posted: 07/26/11
  • resolution changed to fixed

Fixes #2530563 - Fixed alias skin overrides
View Commit: 166b36d2bbb40b8b0ea4fa6b9e9d7349f3b575c4

George

YUI Developer

Posted: 08/18/11
  • status changed from checkedin to closed