Ticket #2530529 (closed defect)

Reporter


Eugene Kashida
Opened: 07/13/11
Last modified: 08/18/11
Status: closed
Type: defect
Resolution: fixed

Owner


Ryan Grove
Target Release: 3.4.0
Priority: P3 (normal)
Summary: Bad check when tacking on non-highlighted remainder of haystack
Description:

Off-by-one check for remaining haystack chars causes unexpected behavior when there is only one char remaining on the haystack.

Current behavior:
Y.Highlight.allFold('dsw', 'ds')
=> <b class="yui3-highlight">ds</b>

Expected behavior:
Y.Highlight.allFold('dsw', 'ds')
=> <b class="yui3-highlight">ds</b>w

Type: defect Observed in Version: development master
Component: Highlight Severity: S3 (normal)
Assigned To: Ryan Grove Target Release: 3.4.0
Location: Library Code Priority: P3 (normal)
Tags: Relates To:
Browsers: All
URL:
Test Information:

Change History

Ryan Grove

YUI Developer

Posted: 07/13/11
  • location changed to Library Code
  • milestone changed to 3.4.0
  • priority changed to P3 (normal)
  • status changed from new to accepted

Eugene Kashida

YUI Contributor

Posted: 07/13/11

Ryan Grove

YUI Developer

Posted: 07/13/11
  • completed changed from 0 to 0.1
  • estimated changed from 0 to 0.1
  • sprint changed to sprint 3
  • status changed from accepted to checkedin

Fixed in commit 6e0d529c. Thanks for the report!

Ryan Grove

YUI Developer

Posted: 07/13/11

Whoops, I committed my own fix before I saw your pull request. Same change though. Thanks!

George

YUI Developer

Posted: 08/18/11
  • resolution changed to fixed
  • status changed from checkedin to closed