Ticket #2530384 (closed defect)

Reporter


Satyen Desai
Opened: 06/2/11
Last modified: 08/18/11
Status: closed
Type: defect
Resolution: fixed

Owner


Dav Glass
Target Release: 3.4.0
Priority: P3 (normal)
Summary: Loader default path incorrect, when using it as an offline dependency calculation service
Description:

I end up having to do this to get Loader to set a base path correctly in configurator...

var loader = new Y.Loader({...});

// Set a base path if the user provides one (current.base is the base path the user enters in the text box), else default to yui.yahooapis.com/[version]/build/
if (current.base != "") {
loader.base = current.base;
} else {
loader.base = Y.Env.meta.base + Y.Env.meta.root;
}

loader.calculate();

a) The default base path doesn't seem to be accurate - hence the workaround in the "else" block (see #2528905).
b) Should loader pick up the base path from whatever is set for the YUI instance it's inside? Without the code in the "if" block above, it doesn't seem to.

Type: defect Observed in Version: 3.3.0
Component: Loader Severity: S3 (normal)
Assigned To: Dav Glass Target Release: 3.4.0
Location: Library Code Priority: P3 (normal)
Tags: Relates To:
Browsers: N/A
URL:
Test Information:

Change History

Dav Glass

Posted: 06/2/11
  • milestone changed to 3.4.0
  • status changed from new to accepted

Dav Glass

Posted: 06/2/11
  • estimated changed from 0 to 1
  • remaining changed from 0 to 1
  • sprint changed to sprint 3

Dav Glass

Posted: 06/28/11
  • remaining changed from 1 to 0.1
  • status changed from accepted to checkedin

The documentation actually specified that this property was supposed to be set to Y.Env.meta.base + Y.Env.meta.root, it was only setting it to Y.Env.meta.base.

Dav Glass

Posted: 06/28/11
  • resolution changed to fixed

Fixes #2530384 - Added Y.Env.meta.root to self.basenn The documentation actually specified that this property wasn supposed to be set to Y.Env.meta.base + Y.Env.meta.root, butn it was only setting it to Y.Env.meta.base.n All Loader tests pass after changing this.
View Commit: 505cbd80dc76c34fedb75216e7168c1af94392a0

Dav Glass

Posted: 06/30/11
  • completed changed from 0 to 0.1
  • remaining changed from 0.1 to 0

George

YUI Developer

Posted: 08/18/11
  • status changed from checkedin to closed