Ticket #2530305 (closed defect)
Reporter Ben Joffe |
Opened: 05/25/11 Last modified: 08/18/11 Status: closed Type: defect Resolution: fixed |
Owner Ryan Grove |
Target Release: 3.4.0 Priority: P3 (normal) |
|---|---|---|---|
| Summary: | [Pull Request] - Made history hash replace() work when a <base> html attribute exists. | ||
| Description: | If the page has a <base href="http://somedomain.com/" /> element defined on the page, then history-hash replaceHash function will cause the page to actually change when calling location.replace('#' + |
||
| Type: | defect | Observed in Version: | development master |
| Component: | History | Severity: | S3 (normal) |
| Assigned To: | Ryan Grove | Target Release: | 3.4.0 |
| Location: | Library Code | Priority: | P3 (normal) |
| Tags: | pull request, github | Relates To: | |
| Browsers: | All | ||
| URL: | https://github.com/benjoffe/yui3/commit/4ffa87a2138d1d3345c23de063ae43e25865f6dc | ||
| Test Information: | |||
Change History
|
Posted: 05/25/11
|
|
Posted: 05/25/11
|
|
Posted: 05/25/11
It seems some of the changes I just made were automatic (all I tried to do was change the type/component): "owner changed from George to Ryan Grove |
|
Posted: 05/25/11
|
|
Posted: 06/13/11
Pulled. Thanks Ben! |
|
Posted: 08/18/11
|
Pull Request from benjoffe
Commit: /benjoffe/yui3/commit/4ffa87a2138d1d3345c23de063ae43e25865f6dc
Files modified: