Ticket #2530305 (closed defect)

Reporter


Ben Joffe
Opened: 05/25/11
Last modified: 08/18/11
Status: closed
Type: defect
Resolution: fixed

Owner


Ryan Grove
Target Release: 3.4.0
Priority: P3 (normal)
Summary: [Pull Request] - Made history hash replace() work when a <base> html attribute exists.
Description:

If the page has a <base href="http://somedomain.com/" /> element defined on the page, then history-hash replaceHash function will cause the page to actually change when calling location.replace('#' +
..), surely unexpected behavior. The solution is to explicitly define the whole path.

Type: defect Observed in Version: development master
Component: History Severity: S3 (normal)
Assigned To: Ryan Grove Target Release: 3.4.0
Location: Library Code Priority: P3 (normal)
Tags: pull request, github Relates To:
Browsers: All
URL: https://github.com/benjoffe/yui3/commit/4ffa87a2138d1d3345c23de063ae43e25865f6dc
Test Information:

Change History

Ben Joffe

YUI Contributor

Posted: 05/25/11

Pull Request from benjoffe
Commit: /benjoffe/yui3/commit/4ffa87a2138d1d3345c23de063ae43e25865f6dc
Files modified:

Ben Joffe

YUI Contributor

Posted: 05/25/11
  • component changed from None to History
  • owner changed from George to Ryan Grove
  • status changed from new to assigned
  • type changed from task to defect

Ben Joffe

YUI Contributor

Posted: 05/25/11

It seems some of the changes I just made were automatic (all I tried to do was change the type/component):

"owner changed from George to Ryan Grove
status changed from new to assigned "

Ryan Grove

YUI Developer

Posted: 05/25/11
  • location changed to Library Code
  • milestone changed to 3.4.0
  • status changed from assigned to accepted

Ryan Grove

YUI Developer

Posted: 06/13/11
  • completed changed from 0 to 0.1
  • remaining changed from 1 to 0
  • status changed from accepted to checkedin

Pulled. Thanks Ben!

George

YUI Developer

Posted: 08/18/11
  • resolution changed to fixed
  • status changed from checkedin to closed