Ticket #2530145 (closed task)
Reporter  Ben Joffe |
Opened: 04/21/11 Last modified: 12/12/12 Status: closed Type: task Resolution: fixed |
Owner  Derek Gathright |
Target Release: 3.7.0 Priority: P3 (normal) |
|---|---|---|---|
| Summary: | [Pull Request] - Fix pages.scrollTo to actually update index + simplifying. | ||
| Description: | A bug exists in paginator where calling scrollTo(n) will visually scroll it, but won't updater index, so the scrollview is in a broken state (eg. a subsequent prev() call will not be correct). Fixing |
||
| Type: | task | Observed in Version: | development master |
| Component: | ScrollView | Severity: | S3 (normal) |
| Assigned To: | Derek Gathright | Target Release: | 3.7.0 |
| Location: | Priority: | P3 (normal) | |
| Tags: | pull request, github | Relates To: | |
| Browsers: | All | ||
| URL: | https://github.com/benjoffe/yui3/commit/ffc2d826cae7c9682e1ed6499dcc53f16b544b2c | ||
| Test Information: | |||
Change History
|
Posted: 04/21/11
|
|
Posted: 04/21/11
Note, this makes one observable change to the user. Previously the workaround to this bug was to use pages.set('index', n) which would animate to the new index. This will no longer animate to the new index but snap there, this seems logical since scrollTo(n) does not animate unless a duration is provided. |
|
Posted: 04/27/11
|
|
Posted: 04/27/11
|
|
Posted: 06/23/11
|
|
Posted: 06/27/11
|
|
Posted: 06/28/11
|
|
Posted: 08/10/11
|
|
Posted: 08/24/11
|
|
Posted: 08/24/11
Backlog for 3.4.1 |
|
Posted: 09/27/11
|
|
Posted: 11/7/11
|
|
Posted: 11/9/11
|
|
Posted: 11/9/11
|
|
Posted: 12/14/11
|
|
Posted: 01/31/12
|
|
Posted: 03/26/12
Additionally, when setting the index it should be possible to define whether you want it to animate the scrollTo or not. At the moment an index change will call scrollTo with hardcoded animation settings: _uiIndex: function(index) { As a user you should be able to call: sv.pages.set("index", N, customAnimationOrNoAnimation) This then brings up the discussion of whether or not we should have a single method instead of two public methods that basically do the same thing. I can’t imagine a scenario where you’ll ever want to call scrollTo and not update the index or update the index and not call a scrollTo but I’ll let you decide that. |
|
Posted: 03/27/12
|
|
Posted: 03/27/12
|
|
Posted: 07/21/12
|
|
Posted: 08/1/12
Moving 3.7.0 bugs to 3.6.x for triage. |
|
Posted: 08/7/12
|
|
Posted: 08/7/12
|
|
Posted: 08/30/12
This was resolved with the large refactoring that occurred in ScrollView for the recently released 3.7.0pr1 version. I'm not sure this resolve's Adriano's suggestion. New ticket for that @ #2532698 |
|
Posted: 09/18/12
Moving from 3.6.x to 3.7.0. |
|
Posted: 12/12/12
|
|
Posted: 12/12/12
|
Pull Request from benjoffe
Commit: /benjoffe/yui3/commit/ffc2d826cae7c9682e1ed6499dcc53f16b544b2c
Files modified: