YUI 3

Ticket #2529113 (closed defect)

Reporter


Ryan Cannon 		Opened: 07/26/10
Last modified: 08/19/10
Status: closed
Type: defect
Resolution: fixed

Owner


Allen Rabinovich 		Target Release: 3.2.0
Priority: P3 (normal)
Summary: [Pull Request] - Fixes logic in isFlashVersionAtLeast()
Description:

Adds additional tests and fixes faulty logic in Y.SWFDetect that does not accurately compare a supplied Flash version if minor version and revision are omitted. Also refactors variable assignments for
better compression.

CLA was mailed on 23 July.
Type: defect Observed in Version: development master
Component: SWFDetect Severity: S4 (low)
Assigned To: Allen Rabinovich Target Release: 3.2.0
Location: Library Code Priority: P3 (normal)
Tags: pull request, github Relates To:
Browsers: All
URL: http://github.com/RCanine/yui3/commit/eac8e62b1c9b262f8c134bd4e427b969abda58c5
Test Information:

The following statements incorrectly log false:

YUI().use('swfdetect', function(Y) {

    Y.log(Y.SWFDetect.isFlashVersionAtLeast(Y.SWFDetect.getFlashVersion()));

    Y.log(Y.SWFDetect.isFlashVersionAtLeast(Y.UA.flashMajor));

    Y.log(Y.SWFDetect.isFlashVersionAtLeast(Y.UA.flashMajor, Y.UA.flashMinor));

});

Workaround: provide all three arguments.

Change History

Ryan Cannon

YUI Contributor
Posted: 07/26/10

Pull Request from rcanine
Commit: http://github.com/RCanine/yui3/commit/eac8e62b1c9b262f8c134bd4e427b969abda58c5
Files modified:

Ryan Cannon

YUI Contributor
Posted: 07/26/10
  • severity changed from S3 (normal) to S4 (low)
  • type changed from task to defect

Eric Miraglia

YUI Contributor
Posted: 08/5/10

Allen Rabinovich

YUI Developer
Posted: 08/12/10
  • milestone changed to 3.2.0
  • status changed from assigned to accepted

George

YUI Developer
Posted: 08/17/10
  • location changed to Library Code

Allen Rabinovich

YUI Developer
Posted: 08/19/10
  • resolution changed to fixed
  • status changed from accepted to closed

© 2006-2013 Yahoo! Inc. All rights reserved.
All code on this site is licensed under the BSD License unless stated otherwise.
About This Site · Security Contact Info