YUILibrary - Open source JavaScript and CSS for building richly interactive software.
Fork YUI on GitHub

YUI 2.x

Ticket #2528714 (assigned defect)

Reporter


davidsickmiller
Opened: 01/5/10
Last modified: 01/5/10
Status: assigned
Type: defect

Owner


Allen Rabinovich
Target Release: 2.NEXT
Priority: P3 (normal)
Summary: Express install no longer works for Flash 6 and Flash 7
Description:

Charts v2.7.0 used a Flash express install technique that worked in Flash Player 6.0.65 and up. In 2.8.0, Charts uses the new SWF component that has a different express install technique which only
works in v8 and up. Corporate Windows XP SP3 workstations are still liable to have Flash 6.0.88, and this is also the Flash version in the IE VHD images published by Microsoft.

This is a regression for the Charts component, but the code is now in the SWF component, so I'm not sure how to assign the ticket.

Fortunately, the patch seems to be quite simple. If you think this is a nontrivial patch, I would be happy to sign a release, submit it via github, or whatever:


--- swf.js

+++ swf.js

@@ -133,9 +133,16 @@
var oElement = Dom.get(p_oElement);
var flashVersion = (p_oAttributes["version"] || FLASH_VER);
var isFlashVersionRight = SWFDetect.isFlashVersionAtLeast(flashVersion);
- var canExpressInstall = (UA.flash >= 8.0);

+ var canExpressInstall = (UA.flash >= 6.0);

var shouldExpressInstall = canExpressInstall && !isFlashVersionRight && p_oAttributes["useExpressInstall"];
- var flashURL = (shouldExpressInstall)?EXPRESS_INSTALL_URL:swfURL;

+ if (shouldExpressInstall) {

+ if (UA.flash < 8.0 && p_oAttributes["expressInstall"])

+ var flashURL = p_oAttributes["expressInstall"];

+ else

+ var flashURL = EXPRESS_INSTALL_URL;

+ } else {

+ var flashURL = swfURL;

+ }
var objstring = '<object ';
var w, h;
var flashvarstring = "YUISwfId=" + _id + "&YUIBridgeCallback=" + EVENT_HANDLER;

Type: defect Observed in Version: 2.8.0
Component: SWF Severity: S3 (normal)
Assigned To: Allen Rabinovich Target Release: 2.NEXT
Location: Library Code Priority: P3 (normal)
Tags: Relates To:
Browsers: N/A
URL:
Test Information:

Change History

Tripp Bridges

YUI Developer

Posted: 01/5/10
  • component changed from Charts to SWF
  • location changed to Library Code
  • milestone changed to 2.NEXT
  • owner changed from Tripp Bridges to Allen Rabinovich
  • priority changed to P3 (normal)
  • status changed from new to assigned