Forwarding to component owner for consideration.

Forwarding to component owner for consideration.

Hi Again,

Just to let you know I have an updated version of the form validator with better documentation. I expect to upload this within the next day or so.

This ticket was imported from Source Forge.

Orginially submitted by: murdog05

With YUI on GitHub, you can fork the yui2 project, add your code in and click the Pull Request button.

Hey there,

I know I said that I was going to post an update 5 months ago and still haven't. I have been busy with a new job and other things so I haven't had a chance. But I fully plan on getting an update to you guys, that is if you guys still want me to send an update. If you do, do you want me to post the updates on GitHub? like you said?

The code is ready, it is fully commented, I just want to take a week or so to provide some additional examples, and fix up the existing ones.

So let me know if you want the update and if you need anything else from me.

Yes, you should absolutely fork the yui2 project and add your code. You should sign a CLA as well if you haven't already done so (http://developer.yahoo.com/yui/community/contribute.html)

When you've added your module code, send a pull request.

We're about to start another cycle of 2.x branch development, so we should have some time to review your work for style, completeness, and A-grade compatibility. Awesome that you've been dedicated to amble examples and docs! Thanks for sharing!

Ah, I already have your pull request. Have you sent in a CLA?

Hi Lucas,

I have not sent in a CLA yet, but I am in the process of downloading and it mailing it right now. Hopefully it will get there in a timely manner. As for the contribution, if there is anything you need from me, don't hesitate to ask. Some of the code is old, and could be done better, but thats how it goes with widgets you always figure out a way to do things better after you finish.

Hi Luke,

I was thinking of doing some more updates to the form validator. One of the updates would be to convert all my events to actual YUI events instead of calling a function directly using a global instance of the object. I know this is not a good coding practice and not done anywhere in YUI, so I thought this update would help you out with getting the validator ready to go into the YUI code base. Let me know if this will help you and I will start updating the component.

Absolutely keep developing on it. Have you explored YUI 3 at all?

I have looked a little bit at it and watched a few of the video posts. From what I see from it thus far, it is a great idea, especially because it allows multiple versions of multiple javascript libraries to be used in one application without collisions or a performance hit.

I will take a closer, more indepth look at it and see if I can change my validator to fit into the practices you guys are following in YUI 3. If you have any useful links that ouline the practices that should be followed in YUI 3 feel free to point me in the right direction.

Hi Luke,

Just an update on the form validator. I have started re-writing it using the YUI3 framework (which is fantastic by the way). I am hoping to have the form validator completely re-written in YUI3 in about a month and a half, maybe two months at the most.

That's awesome Murray. We are maintaining concurrent production lines in 2.x and 3.x, so I hope you're not destroying the YUI 2 work in the process.

I'm glad you're liking YUI 3. It's still pretty new, so there aren't too many articles out there about it, and I suspect it's too early to find a "best practices" article about using it. mattsnider.com has a couple and klauskomenda.com has one. Otherwise, the docs on developer.yahoo.com/yui/3 and a web search for '"YUI 3" javascript' or '"YUI 3" Yahoo' should get you some decent content. Also, Dav and I have some modules on github.com/lsmith and /davglass that you can reference. There has been a decent amount of movement in the core since some of those were created, so you've been warned :)

If you run into any problems or have any questions, I'd be glad to help.

Hi Luke,

My YUI 2 code base is still intact. The YUI 3 version is a complete re-write, and so far, I am very happy with the results. My code is MUCh cleaner and follows all of the best practices you guys recommend. I used Matt Snider's blog where he compared YUI 2 to YUI 3 as a starting point for my code, and used his style of syntax as the basis. It seems like a solid approach and so far its working out great.

Thanks for your recommendations, and if I have any difficulties I will definitely ask! Thanks!

Hi Luke,

Just an update on the form validator. I have finished re-writing it for YUI 3, and have updated all the examples I had sent in the pull request. All that is left is for me to fix up my comments, update the documentation page, and re-submit it. I should be done all this in a week or two. I am assuming you will want me to make branch off the yui3 repository on github and then do a pull request.

Hi Luke,

The form validator is all done for YUI 3. Its fully commented and comes with a bunch of examples as well as a tutorial page that explains how to use the form validator. The comments are compatible with the YUI doc compiler so you documentation should be easy to generate.

Right now I am trying to upload it to my repository that was forked from YUI 3, but git hub is giving me an error page. I will upload id as soon as possible. What is the desired format? Would you like everything zipped, or would like each file uploaded on its own?

I took a look on your github yui3 fork and couldn't find the validator code.

Sorry I've been so unresponsive lately! In part this was due to the fact that I really wanted to suggest you submit the validator as a YUI 3 Gallery module, but the Gallery wasn't officially announced yet :)

Going the Gallery route would be a great way to get your code out there to the public and hosted on our CDN without having to wait for us to do official code reviews. You can get a quick howto at http://yuilibrary.com/gallery/

I'm still interested in getting an official Forms package into both YUI 2 and YUI 3, though. I'm sure your contribution will be instrumental in making that happen. We don't have a Gallery for YUI 2, so the core contribution is the only route available there.

Let me know where you put the API and I'll schedule some time to have a look over the code. In the mean time, create a Gallery module for the YUI 3 implementation and link me to the module page when that's created. And of course, let me know if you have questions!

Thanks again (and again for good measure for your patience)

Hi Luke,

Sure thing, I will create a gallary as soon as possible. Right now I am having issues with GitHub, it keeps telling me my Repository is Under Migration and won't let me upload the files. I will try and get all my stuff setup properly on Github and then I will let you know.

Hi Luke,

Took me awhile but I finally figured out how to get stuff up on git hub properly. So far I have been unsuccessful in getting my user pages to work. For instance if I got to http://murdog05.github.com/ I get an error page. I have followed the instructions on the page, but so far I haven't gotten anything to work.

However, if you want to look at the YUI3 code it is at http://github.com/murdog05/murdog05.github.com.

I did see another form component in the YUI gallery, someone seems to have had a similar idea as mine, so I want to try and get my gallery component up as soon as possible because I think mine is more functional than his.

If you have any good page references on git hub, that would be great, if not, I will keep plugging along.

Hi Luke,

Thanks for pointing me in the direction of the gallery. I have got my form validator code for YUI3 up and it has been approved for CDN. I like the system, makes it really easy for someone to contribute code!

On that note, while I was preparing my code to go into the gallery, I realized that my form validator for YUI 2 to would not likely make it through the YUI builder for YUI 2. This is due to the fact that I wrote the YUI2 version of the form validator awhile ago, before I learned a lot of the Javascript best coding practices. So the next step will be for me to take what I have written for the YUI3 form validator, and port it over to YUI2. I think this will make your life a lot easier when you try and bring it in to YUI 2.

I will keep you updated on my progress,

That's awesome Murray. Thanks for your dedication!

I found your gallery module and will take a look at it next week (ooo rest of this week).

Hi Luke,

I have finished the YUI2 version of the form validator. I just took the code from the YUI3 form validator (which is clean) and ported it over to the YUI2 framework using Matt Sniders blog about YUI2 vs YUI3 as a guide (http://mattsnider.com/languages/javascript/comparing-widget-in-y2-versus-y3/).

I have commited all the files to git hub (http://github.com/murdog05/yui2), and I have also posted my examples for the YUI2 version as well (http://murdog05.github.com/yui2/).

Its ready to go, so whenever you want me to, just give me the go ahead and I will issue a pull request.

P.S.

I didn't generate any documenation for it as I assume that you guys do that. If you need it, just let me know and I will be happy to generate the YUI docs for you.