Forums

Board index » YUI 3 Gallery Forums: » Gallery Forums » Simple Menu

Page 1 of 1   [ 6 posts ]
New Topic | Post Reply | Print view

Eric Miraglia

YUI Contributor

  • Username: miraglia
  • Joined: Tue Sep 02, 2008 10:59 am
  • Posts: 205
  • Location: Los Gatos, CA
  • Twitter: miraglia
  • GitHub: miraglia
  • Gists: miraglia
  • Offline
  • Profile
Tags:

Simple example to augment documentation

Post Posted: Fri Feb 12, 2010 10:56 am
+2-
Julien -- fantastic contribution to the gallery -- thank you.

For anyone interested in using this, I wrote up a very simple example with some notes about usage:

http://ericmiraglia.com/yui/demos/simplemenu.php

Joe Developer

  • Username: JoeDev
  • Joined: Sat May 09, 2009 12:54 am
  • Posts: 73
  • Twitter: joe_developer
  • IRC: unomi
  • Offline
  • Profile

Re: Simple example to augment documentation

Post Posted: Fri Feb 12, 2010 1:09 pm
+0-
That really is very nice.

Thanks Julien. :)

Joe Developer

  • Username: JoeDev
  • Joined: Sat May 09, 2009 12:54 am
  • Posts: 73
  • Twitter: joe_developer
  • IRC: unomi
  • Offline
  • Profile

Re: Simple example to augment documentation

Post Posted: Fri Feb 12, 2010 11:36 pm
+0-
One thing which would be really nice is if creation from a json config could get in there.

Eric Miraglia

YUI Contributor

  • Username: miraglia
  • Joined: Tue Sep 02, 2008 10:59 am
  • Posts: 205
  • Location: Los Gatos, CA
  • Twitter: miraglia
  • GitHub: miraglia
  • Gists: miraglia
  • Offline
  • Profile
Tags:

Re: Simple example to augment documentation

Post Posted: Sun Feb 14, 2010 9:04 pm
+0-
JoeDev,

I'd encourage you to fork the code and submit a slightly modified version to the gallery with "build from script" support to do what you're describing (Julien has issued this under BSD, so that kind of work is permitted and encouraged). In most of the projects I work on, I'd want the progressive enhancement route, and I love how light this script is -- in part because it only tries to do one simple (but common) thing. But as soon as I had a circumstance arise where I wanted to build the menu from script, I'd want the enhancement you're contemplating.

-Eric

David Lantner

  • Username: davidlantner
  • Joined: Tue Feb 16, 2010 9:36 am
  • Posts: 1
  • Location: Washington, D.C.
  • Twitter: davidlantner
  • GitHub: davidl
  • Gists: davidl
  • Offline
  • Profile
Tags:

Re: Simple example to augment documentation

Post Posted: Tue Feb 16, 2010 10:21 am
+0-
In Julien's description of the Simple Menu module, the "expected markup" includes a link with an "id" of "menu-link" but the module supplies a hard-coded value of "more-link" for the "aria-labelledby" attribute that is added to "#optionsmenucontainer":

http://github.com/yui/yui3-gallery/blob/master/src/gallery-simple-menu/js/simple-menu.js#L28

I forked the code to grab the "id" of the link (the element on which Simple Menu is applied):

http://github.com/davidl/yui3-gallery/c ... af78752ed8

I received an auto-response to submit a pull request on this site but no requests are found for me - is this because I forked "yui/yui3-gallery" and not "yui"? More importantly, as this is a small change (and I am new to using github, this site, and YUI in general) please feel free to make the change as you see fit. And keep up the great work!

Regards,
David

Eric Miraglia

YUI Contributor

  • Username: miraglia
  • Joined: Tue Sep 02, 2008 10:59 am
  • Posts: 205
  • Location: Los Gatos, CA
  • Twitter: miraglia
  • GitHub: miraglia
  • Gists: miraglia
  • Offline
  • Profile
Tags:

Re: Simple example to augment documentation

Post Posted: Tue Feb 16, 2010 12:28 pm
+0-
David,

Thanks for forking and pitching in right away on this one.

In this case -- with a Gallery module that you want to make a contribution to -- you should fork off of Julien's repo and issue the pull request to him directly. He's the curator of this component, so he'd make all decisions about inbound changes.

http://github.com/jlecomte/yui3-gallery ... mple-menu/

Because this is a BSD-licensed component, Julien will need confirmation that you've signed a YUI CLA -- please make sure to do that as well:

http://developer.yahoo.com/yui/community/index.html

-Eric
Page 1 of 1   [ 6 posts ]
New Topic | Post Reply | Print view
Display posts from previous:  Sort by  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum

Recent Forums Posts

Recent YUI Blog Posts

Online Users

No Users Online

© 2006-2013 Yahoo! Inc. All rights reserved.
All code on this site is licensed under the BSD License unless stated otherwise.
About This Site · Security Contact Info

Powered by phpBB® Forum Software © phpBB Group