Problem with skin override yui 3.5.0

Board index » YUI 3.x: » CSS

Page 1 of 1

[ 9 posts ]

New Topic | Post Reply | Print view

Previous topic | Next topic

Marc

YUI Contributor

Username: mschipperheyn
Joined: Wed Jul 29, 2009 11:04 am
Posts: 372
GitHub: mschipperheyn
Gists: mschipperheyn

Tags:

Problem with skin override yui 3.5.0

Posted: Wed Apr 11, 2012 7:04 am

+0-

Hi,

I have a problem with skin override on a widget that didn't occur in 3.4.1. This maybe because yui 3.4.1 was more forgiving of something I did wrong. The problem is:

1. Skin override doesn't seem to work reliably anymore. On my widget most of the time the default sam css is loaded and applied.
2. If the skin does get loaded, you briefly see the sam skin applied and then the correct skin is applied.

My code is like so:

Code:

YUI_config.skin = {
   overrides:{
      'gallery-slidecheckbox':['ios5-green']
   }
}
<div class="yui3-skin-ios5-green">
<input type="checkbox" name="myCheck1" class="yesno" id="c1" class="slidecheck">
</div>

The css is part of a gallery widget (I am the author): slide checkbox.

I assume that this is because of changes to the Loader module which may be exposing some issue in my code, I didn't realize was there. If there's a way to handle this issue I would love to hear about it.

Kind regards,
Marc

Scott Steffens

Username: scotts
Joined: Tue Apr 17, 2012 8:43 pm
Posts: 2

Tags:

skins performance bug

Re: Problem with skin override yui 3.5.0

Posted: Tue Apr 17, 2012 8:51 pm

+0-

We're also experiencing this problem, resulting in a significant performance degradation due to extraneous skins being loaded. Is this a known bug or an API change?

Dav Glass

Username: davglass
Joined: Thu Aug 28, 2008 9:28 am
Posts: 2088
Location: Marion, IL, US
Twitter: davglass
GitHub: davglass
Gists: davglass
IRC: davglass

Re: Problem with skin override yui 3.5.0

Posted: Wed Apr 18, 2012 4:34 am

+0-

@Mark --

Can you post a repro link (to jsfiddle or something) so I can see it happen?

Scott Steffens

Username: scotts
Joined: Tue Apr 17, 2012 8:43 pm
Posts: 2

Re: Problem with skin override yui 3.5.0

Posted: Wed Apr 18, 2012 8:26 am

+0-

I filed a bug with a repro case:

http://yuilibrary.com/projects/yui3/ticket/2532168

Marc

YUI Contributor

Username: mschipperheyn
Joined: Wed Jul 29, 2009 11:04 am
Posts: 372
GitHub: mschipperheyn
Gists: mschipperheyn

Tags:

Re: Problem with skin override yui 3.5.0

Posted: Thu Jun 14, 2012 4:52 am

+0-

With 3.6.0pr2, I have a new/similar problem. Now, the skin is not loaded on one component but it is on another.

I use

Code:

YUI_config.skin = {
   overrides:{
      'gallery-fb-statusfield':['green']
   }
};

YUI_config.groups.mygallery={
   base:'./js/yui-library/',
   combine:true,
   comboBase:YUI_config.serverUrl +  '/yui/' + YUI_config.version + '/?',
   root:'yui-library/',
   modules:{
'gallery-fb-statusfield':{requires:["widget-base","io-base","event-key","substitute","node-style"],skinnable:true}

Until 3.6.0pr2, this worked. With 3.6.0pr2, it loads the default 'sam' skin.

Reading the documentation about skinning, I miss information about skinning components. Only the suggestion that I should statically load a skin or change the skin for the entire page through the loader. This info seems incomplete BTW, because it's missing some relevant info on loading custom skins through components and doesn't mention skin overrides in YUI_Config. Did something change?

I also tried wrapping the component with
<div class="green">

The component is executed as a plugin for a textarea field.

Any suggestions? It looks like a bug given that all things equal, it works before 3.6.0pr2 and not after.

Cheers,
Marc

Dav Glass

Username: davglass
Joined: Thu Aug 28, 2008 9:28 am
Posts: 2088
Location: Marion, IL, US
Twitter: davglass
GitHub: davglass
Gists: davglass
IRC: davglass

Re: Problem with skin override yui 3.5.0

Posted: Thu Jun 14, 2012 5:53 am

+0-

Marc --

Please file a working repro case so I can investigate it.

Marc

YUI Contributor

Username: mschipperheyn
Joined: Wed Jul 29, 2009 11:04 am
Posts: 372
GitHub: mschipperheyn
Gists: mschipperheyn

Tags:

Re: Problem with skin override yui 3.5.0

Posted: Mon Jun 18, 2012 6:55 am

+0-

Ok, I created a repro case and figured out the problem.
Unlike in 3.4.1, if you select a skin override in 3.6.0, it will load both the sam skin and the custom skin. The order in which this happens doesn't seem to be guaranteed at first, which is why I was confused at first because the isolated test seemed to work.

http://yuilibrary.com/projects/yui3/ticket/2532423

Marc

YUI Contributor

Username: mschipperheyn
Joined: Wed Jul 29, 2009 11:04 am
Posts: 372
GitHub: mschipperheyn
Gists: mschipperheyn

Re: Problem with skin override yui 3.5.0

Posted: Fri Jun 29, 2012 4:38 am

+0-

I see that this issue has not been targeted for 3.6.0 yet. I would strongly recommend that it is. I'm sure a lot of people would not want to use 3.6.0 if it doesn't process custom skins properly.

Dav Glass

Username: davglass
Joined: Thu Aug 28, 2008 9:28 am
Posts: 2088
Location: Marion, IL, US
Twitter: davglass
GitHub: davglass
Gists: davglass
IRC: davglass

Tags:

ticket

Re: Problem with skin override yui 3.5.0

Posted: Fri Jun 29, 2012 6:57 am

+0-

I was on vacation last week, and this week has been me catching up so there has been no movement on it because I have yet to triage any of the tickets that were opened while I was away

Page 1 of 1

[ 9 posts ]

New Topic | Post Reply | Print view

Previous topic | Next topic

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum