Small error

Board index » YUI 3 Gallery Forums: » Gallery Forums » Slideshow

This support forum belongs to the Slideshow Gallery Module.
Slideshow has a bug tracker here: http://github.com/foxxtrot/yui3-gallery/issues

Page 1 of 1

[ 1 post ]

New Topic | Post Reply | Print view

Previous topic | Next topic

Marco Asbreuk

YUI Contributor

Username: itsasbreuk
Joined: Mon Nov 16, 2009 5:14 am
Posts: 485
Location: Netherlands
Twitter: itsasbreuk
GitHub: ItsAsbreuk
Gists: ItsAsbreuk
IRC: Marco Asbreuk

Tags:

Small error

Posted: Mon Feb 28, 2011 1:55 pm

+0-

Hi Jeff,

I wanted to make use of your slideshow, but it didn't work when rendering on an empty div.
I think there is a small error in your renderUI function:

Code:

if (title.length > 0) { this._setHeaderContents(title);
if (!Y.Lang.isValue(bodyNode)) { 
    bodyNode = this._addTemplate(this.TEMPLATES.body);
    this.set('bodyNode', bodyNode);
}}

should be:

Code:

if (title.length > 0) { this._setHeaderContents(title);}
if (!Y.Lang.isValue(bodyNode)) { 
    bodyNode = this._addTemplate(this.TEMPLATES.body);
    this.set('bodyNode', bodyNode);
}

Sorry for not posting it on Github: I have not dived in Github yet...
Another small thing: your codeexample mentioned new Y.Slideshow instead of new Y.SlideShow.
Anyway, the slideshow works great now. Thanks for letting me take use of it.

Kind Regards,
Marco.

Page 1 of 1

[ 1 post ]

New Topic | Post Reply | Print view

Previous topic | Next topic

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum